feat(inbox): gate signals inbox behind posthog-code-inbox flag#1828
Open
posthog[bot] wants to merge 5 commits intomainfrom
Open
feat(inbox): gate signals inbox behind posthog-code-inbox flag#1828posthog[bot] wants to merge 5 commits intomainfrom
posthog[bot] wants to merge 5 commits intomainfrom
Conversation
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 60
Comment:
**`CYCLE_START_DELAY_MS` uses all-features count regardless of flag**
`CYCLE_START_DELAY_MS` is a module-level constant computed from `ALL_FEATURES.length` (5), so when inbox is disabled and only 4 features render, the stagger delay before cycling begins is 100 ms longer than necessary. The constant could be moved inside the component (or derived from `features`) to stay in sync with the actual list length.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(inbox): gate remaining inbox surfac..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| const CYCLE_INTERVAL_MS = 2500; | ||
| const CYCLE_START_DELAY_MS = FEATURES.length * 100 + 400; | ||
| const CYCLE_START_DELAY_MS = ALL_FEATURES.length * 100 + 400; |
There was a problem hiding this comment.
CYCLE_START_DELAY_MS uses all-features count regardless of flag
CYCLE_START_DELAY_MS is a module-level constant computed from ALL_FEATURES.length (5), so when inbox is disabled and only 4 features render, the stagger delay before cycling begins is 100 ms longer than necessary. The constant could be moved inside the component (or derived from features) to stay in sync with the actual list length.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 60
Comment:
**`CYCLE_START_DELAY_MS` uses all-features count regardless of flag**
`CYCLE_START_DELAY_MS` is a module-level constant computed from `ALL_FEATURES.length` (5), so when inbox is disabled and only 4 features render, the stagger delay before cycling begins is 100 ms longer than necessary. The constant could be moved inside the component (or derived from `features`) to stay in sync with the actual list length.
How can I resolve this? If you propose a fix, please make it concise.
Hides the sidebar inbox item and the inbox view when the posthog-code-inbox feature flag is disabled. Also skips the sidebar signal-count polling when the flag is off so we don't pay the network cost for users who can't see the inbox. Generated-By: PostHog Code Task-Id: f5d4a0ab-7de3-4bcb-a465-bbcf6cf7c22a
…flag (#1840) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…ed (#1843) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
joshsny
force-pushed
the
posthog-code/gate-inbox-behind-feature-flag
branch
from
8860d13 to
accc99f
Compare
sortafreel
approved these changes
Apr 23, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
auto-merge was automatically disabled
April 23, 2026 11:40
Head branch was pushed to by a user without write access
Contributor
Resolved and pushed in commit I merged
No user-facing UI changes were introduced by this conflict resolution, so there’s no meaningful UI screenshot to share. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Twixes
requested changes
Apr 23, 2026
Member
Twixes
left a comment
Twixes
left a comment
There was a problem hiding this comment.
A couple of things, coming from our Slack thread:
- Inbox should be default rolled-out, with it being gated if the flag is on; it's a core part of PH Code
- the gated state should be a waitlist, something along the lines of "We're just scaling up this feature to provide you with a great experience; sign up and we'll let you know when self-driving is available to you"
…ed logic (#1860) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gates the Signals Inbox behind the
posthog-code-inboxfeature flag (currently rolled out to 100% in PostHog).InboxItemin the sidebar when the flag is offInboxViewinMainLayoutwhen the flag is off, even if the view is navigated touseInboxReports) when the flag is off to avoid unnecessary network requestsFlag: posthog-code-inbox — boolean, 100% rollout.
Test plan
getSignalReportspolling from the sidebar badgeCreated with PostHog Code